CASSGO-82 CASSGO-83 fix tinyint decode bug and vector decode bug with SliceMap #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshartig
reviewed
Jul 3, 2025
jameshartig
reviewed
Jul 3, 2025
jameshartig
reviewed
Jul 3, 2025
jameshartig
reviewed
Jul 3, 2025
jameshartig
approved these changes
Jul 3, 2025
joao-r-reis
force-pushed
the
cassgo-82
branch
2 times, most recently
from
e9f57b4 to
b0b387e
Compare
Tinyint unmarshal silently errors and unmarshals tinyint values as 0 in some situations. This patch also removes other cases of silent errors in decode functions. Fix issue where reading vectors with SliceMap is not possible. Patch by João Reis; reviewed by James Hartig for CASSGO-82, CASSGO-83
jameshartig
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSGO-82
Tinyint unmarshal silently errors and unmarshals tinyint values as 0 in some situations.
This PR also removes other cases of silent errors in decode functions.
CASSGO-83
fix issue where reading vectors with SliceMap is not possible